refactor(fe): use tanstack query for settings page #2308
+94
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-20 16:20:34 CET |
|
Preview에서 실행했을 땐 에러가 발생하지 않는데 재현 영상이 있을까요?? |
eunnbi
reviewed
Feb 17, 2025
Comment on lines
+59
to
+61
| if (!isLoading && defaultProfileValues.major) { | ||
| console.log('Setting majorValue:', defaultProfileValues.major) | ||
| setMajorValue(defaultProfileValues.major) |
There was a problem hiding this comment.
Suggested change
| if (!isLoading && defaultProfileValues.major) { | |
| console.log('Setting majorValue:', defaultProfileValues.major) | |
| setMajorValue(defaultProfileValues.major) | |
| if (defaultProfileValues.major) { | |
| setMajorValue(defaultProfileValues.major) |
console.log 지워주세요!
isLoading 값을 사용할 필요는 없는 것 같아요!
eunnbi
reviewed
Feb 17, 2025
| updateNow: Boolean(updateNow), | ||
| isLoading | ||
| updateNow: Boolean(updateNow) | ||
| //isLoading |
There was a problem hiding this comment.
Suggested change
| //isLoading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
리팩토링 목적: useEffect를 포함한 API 호출 로직을 Tanstack Query로 관리하기
Additional context
Failed to Load Main Page!
Too many re-renders. React limits the number of renders to prevent an infinite loop.
Before submitting the PR, please make sure you do the following
fixes #123).